Image view at github [SOLVED]

User avatar
LesterBoffo
Posts: 766
Joined: Tue Sep 15, 2015 3:58 am
Location: Beautiful sunny, KOTH

Re: Image view at github

Postby LesterBoffo » Sat Oct 01, 2016 5:00 pm

IAHM-COL wrote:
KL-666 wrote:And maybe for the planes without thumbnail you can choose another image?



In my opinion the best solution there is to add missing thumbnails.
People could make really nice ones and sent us a PR and help there

Some aircrafts, while missing we can use the FGMEMBERS missing thumbnail mock image seen in some aircrafts
Image

And, no. It is not finished.
It is just an example of the template.

I want to create a python script that creates the table from a list of repository names.
That way is easy to repopulate/recreate the wiki when one new aircraft is added. Otherwise, it would be a mess to maintain.


That reminds me, that I have to thumbnail nearly all of my aircraft and vehicles... :roll:

User avatar
IAHM-COL
Posts: 6409
Joined: Sat Sep 12, 2015 3:43 pm
Location: Homey, NV (KXTA) - U.S.A
Contact:

Re: Image view at github

Postby IAHM-COL » Sat Oct 01, 2016 5:03 pm

KL-666 wrote:I'd give 3 cols a try first. See how it looks. If not too bad, it should be fine.

Kind regards, Vincent



Done
I updated the Lists to three columns and pushed a change in the wiki/sources file to create 3-column outputs

IH-COL
https://raw.githubusercontent.com/IAHM-COL/gpg-pubkey/master/pubkey.asc

R.M.S.
If we gave everybody in the World free software today, but we failed to teach them about the four freedoms, five years from now, would they still have it?

KL-666
Posts: 1610
Joined: Mon Sep 28, 2015 8:42 am

Re: Image view at github

Postby KL-666 » Sat Oct 01, 2016 5:14 pm

Looks better than with the cutoff last row. To me it is fine like this. But are you really sure that github does not allow you to add an attribute to the img tag? Like: style="max-width:x; max-height:y;".

Kind regards, Vincent

User avatar
IAHM-COL
Posts: 6409
Joined: Sat Sep 12, 2015 3:43 pm
Location: Homey, NV (KXTA) - U.S.A
Contact:

Re: Image view at github

Postby IAHM-COL » Sat Oct 01, 2016 5:35 pm

I'm not sure of that. It probably does. Fix that should be quite easy too :D

I'll research. It should be easy to adapt the python fuctions to add parameters to the files

I actually decided to keep the sources for both 3 col and 4 col parsers
https://github.com/FGMEMBERS/wiki/tree/master/sources
https://raw.githubusercontent.com/IAHM-COL/gpg-pubkey/master/pubkey.asc

R.M.S.
If we gave everybody in the World free software today, but we failed to teach them about the four freedoms, five years from now, would they still have it?

User avatar
IAHM-COL
Posts: 6409
Joined: Sat Sep 12, 2015 3:43 pm
Location: Homey, NV (KXTA) - U.S.A
Contact:

Re: Image view at github

Postby IAHM-COL » Sat Oct 01, 2016 5:37 pm

it says here that I can replace the markdown code for raw html code to achieve any desired resizing on the html parsed from the markdown code
http://stackoverflow.com/questions/2438 ... g-markdown
https://raw.githubusercontent.com/IAHM-COL/gpg-pubkey/master/pubkey.asc

R.M.S.
If we gave everybody in the World free software today, but we failed to teach them about the four freedoms, five years from now, would they still have it?

User avatar
IAHM-COL
Posts: 6409
Joined: Sat Sep 12, 2015 3:43 pm
Location: Homey, NV (KXTA) - U.S.A
Contact:

Re: Image view at github

Postby IAHM-COL » Sat Oct 01, 2016 5:38 pm

So, the question now is
Should I try to get the 4 column version working with enforced image width? or should I move on with the current 3col rendering?
https://raw.githubusercontent.com/IAHM-COL/gpg-pubkey/master/pubkey.asc

R.M.S.
If we gave everybody in the World free software today, but we failed to teach them about the four freedoms, five years from now, would they still have it?

KL-666
Posts: 1610
Joined: Mon Sep 28, 2015 8:42 am

Re: Image view at github

Postby KL-666 » Sat Oct 01, 2016 5:45 pm

If you can add that attribute, you may also be able to add the style attribute, which does not stretch too small images (max sizes). Limiting size is in any case a good idea, because someone may put in a really large thumbnail. If it fits 4 rows with limiting size to the standard thumb size (you do not want to malform most of the images) then 4 rows, else 3.

Kind regards, Vincent

User avatar
IAHM-COL
Posts: 6409
Joined: Sat Sep 12, 2015 3:43 pm
Location: Homey, NV (KXTA) - U.S.A
Contact:

Re: Image view at github

Postby IAHM-COL » Sat Oct 01, 2016 5:49 pm

I'll try...
Standby
https://raw.githubusercontent.com/IAHM-COL/gpg-pubkey/master/pubkey.asc

R.M.S.
If we gave everybody in the World free software today, but we failed to teach them about the four freedoms, five years from now, would they still have it?

User avatar
IAHM-COL
Posts: 6409
Joined: Sat Sep 12, 2015 3:43 pm
Location: Homey, NV (KXTA) - U.S.A
Contact:

Re: Image view at github

Postby IAHM-COL » Sat Oct 01, 2016 6:19 pm

@KL-666

I constrained the image width. Then I used 4 column. Going image as small as 100 px width did not help at all, and the column kept going off boundaries. It happens because some aircraft names were too long to fit the table (and thus image had nothing to do with it anymore)

So, the conclussion after lots of testing was

* it is better to keep 3 column table
* it is better to constrain thumbnail image to width="171" (as the FG standard), so that keeps all table printing quite neatly on 3 columns, regardless someone pushing an oversized thumbnail to the repo.

Take a look :D

https://github.com/FGMEMBERS/wiki/commi ... f0791d36bf

IH-COL
https://raw.githubusercontent.com/IAHM-COL/gpg-pubkey/master/pubkey.asc

R.M.S.
If we gave everybody in the World free software today, but we failed to teach them about the four freedoms, five years from now, would they still have it?

User avatar
IAHM-COL
Posts: 6409
Joined: Sat Sep 12, 2015 3:43 pm
Location: Homey, NV (KXTA) - U.S.A
Contact:

Re: Image view at github

Postby IAHM-COL » Sat Oct 01, 2016 6:25 pm

https://raw.githubusercontent.com/IAHM-COL/gpg-pubkey/master/pubkey.asc

R.M.S.
If we gave everybody in the World free software today, but we failed to teach them about the four freedoms, five years from now, would they still have it?


Return to “FGMEMBERS”

Who is online

Users browsing this forum: No registered users and 6 guests